| name | edit-pr |
| description | Edit a pre-existing GitHub pull request for OpenFirma. Use whenever you are asked to make changes to commits, branches or bookmarks that would affect an open GitHub PR. |
Edit PR
Use this workflow whenever you are asked to make changes to commits, branches or bookmarks
that would affect an open GitHub pull request for OpenFirma.
Terminology
A PR is defined as protected if a user that's clearly not a bot has submitted a review or
left a review or issue comment on it.
Initial analysis
- Inspect the repository state and active VCS.
- Determine the impacted PRs:
- If working with
git, use branch names to find corresponding PRs.
- If working with
jj, use bookmark names to find corresponding PRs.
- For each impacted PR, determine if it's protected or not.
If the PR is protected, see [#protected-pr-workflow].
Otherwise, follow [#non-protected-pr-workflow].
Protected PR workflow
You are allowed to rewrite the history of protected PR if and only if you are rebasing on top of the latest changes to the target branch and all your changes to the existing revisions are geared towards resolving the conflict that arose from the rebase.
If that's not the case, all new changes should be packaged as new revisions on top of
the existing ones.
Load and follow the commit-guidelines skill when doing so.
After you're done with your changes, follow the [#push-workflow].
Non-protected PR workflow
If a PR is not protected, you are free to change its history as you see fit.
Follow the [#push-workflow].
Push Workflow
Once the changes you want to push are ready, follow this checklist:
- Load and follow the
verify skill.
Verification must succeed before you move forward.
- Push the new changes.
- Perform an adversarial review.
- Present the adversarial review findings to the user. Do not address or
dismiss any finding until the user has reviewed it and provided explicit
direction.
- Iterate on the outcomes of the previous step according to the user's
direction, until:
- Verification succeeds.
- Findings from the adversarial review have been addressed/dismissed.
- Any resulting changes have been pushed.
- The updated PR has passed another adversarial review, unless the changes
since the previous review are purely mechanical and do not change
behavior or meaning.
- Verify the affected PR body, title, base, and head.
- Update the PR body and/or title with
gh if the new changes
have made the existing one outdated.
- Spin up a background job to monitor to the CI run triggered by the latest push.
It must succeed. If not, failures must be triaged and addressed.
Output
Report the PR URL.
