clean-sonar-findings

name	clean-sonar-findings
description	Use for explicit SonarQube issue cleanup, Sonar code smells, low-risk static-analysis fixes, and touched-scope Sonar remediation. Do not use for normal validation unless cleanup is explicitly requested.

Goal

Resolve low-risk SonarQube findings without mixing static-analysis cleanup with behavior changes. When working from SonarQube server results, resolve every unresolved issue in the requested project or scope. Do not stop because the Quality Gate is green. If any issue remains, report it explicitly with the reason it was not fixed.

Good candidates

• unused imports
• clearly dead commented-out code
• safe String.raw replacements for regex or path backslash readability
• small mechanical boolean or operator simplifications when behavior is obvious

Avoid

• broad style rewrites
• condition inversion churn without a real readability win
• mixed behavior and Sonar cleanup in one patch unless explicitly requested
• claiming Sonar server results unless actually verified
• hand-editing dist/**

Context budget

• query unresolved SonarQube issues for the requested project or scope before deciding cleanup is complete
• start from the explicit Sonar finding or touched scope
• search first, then open only the finding location and nearest tests
• avoid broad tours through src/**
• avoid docs/** unless task-relevant
• stop expanding context when the mechanical fix is clear

Validation

• validate with npm run lint and relevant tests
• use $validate-repo-change for final validation reporting
• if SonarQube is unavailable, report the concrete blocker instead of implying cleanup was server-verified

SonarQube timing

• Full analysis (npm run sonar) takes approximately 2–3 minutes on the local project with a LAN-based SonarQube server.
• When waiting for the analysis to complete, use a background sleep of about 90 seconds before checking the result, then poll again if still processing.
• Issue queries via api/issues/search return instantly and should be used to confirm cleanup instead of re-running full analysis unnecessarily.