| name | review-gates |
| description | Two-stage review gates ensuring both requirement compliance and code quality before merging. |
| source_type | skill |
| source_file | skills/review-gates.md |
review-gates
Migrated from skills/review-gates.md.
Codex packaging notes
- Claude/Telar source files remain the source of truth; this file is the generated Codex adapter.
- Skill-local support files from the original Telar skill, such as
references/... or workflow/..., are packaged beside this SKILL.md.
- Repo-root references from the original Telar file, such as
agents/..., commands/..., scripts/..., resources/..., rules/..., hooks/..., or templates/..., are packaged at this plugin root.
- The original Telar orchestration source (
skills/orchestration/...) is packaged under source/skills/orchestration/... for exact-reference lookups; all other Telar skills exist here only as the generated adapters under the plugin-root skills/ directory.
- Resolve plugin-root paths from this generated skill directory via
../.. when reading support files or running packaged scripts.
Review Gates
Two-stage review gates ensuring both requirement compliance and code quality before merging.
Stage 1: Requirement Compliance
Does the implementation meet the requirements?
1A: REQUIREMENTS.md Compliance
For each F-x and UI-x covered by this implementation:
## Requirements Compliance
| Requirement | Description | Status | Evidence |
|-------------|-------------|--------|----------|
| F-1 | Email auth | PASS | `lib/features/auth/auth_repository.dart` |
| F-7 | Calendar view | FAIL | Missing conflict resolution (F-7 business rule 3) |
| UI-5 | Calendar screen | PASS | `lib/screens/calendar/calendar_screen.dart` |
### Verdict: FAIL (1 unmet requirement)
Action: Implement F-7 business rule 3 before Stage 2
1B: PLAN.md Acceptance Criteria
If PLAN.md and PROGRESS.md exist:
## Task Acceptance Check
| Task | Requirement | Acceptance Criteria | Status |
|------|-------------|--------------------|---------|
| T1 | F-1 | Auth repository initialises without errors | PASS |
| T3 | F-7 | Calendar loads events for current month | PASS |
| T4 | F-7 | Conflict shown when two events overlap | FAIL |
### Verdict: FAIL (1 unmet criterion)
Both 1A and 1B must pass before Stage 2 begins.
Verification requirement: Evidence must be fresh — re-run tests and re-verify on simulator before claiming pass. See verification-before-completion skill.
Stage 2: Code Quality
Does the code follow project standards?
## Code Quality Check
### Architecture
- [ ] Follows existing project structure
- [ ] No circular dependencies
- [ ] Appropriate separation of concerns
### Patterns
- [ ] Matches existing state management approach
- [ ] Consistent error handling pattern
- [ ] Proper loading state management
- [ ] API responses validated
### Performance
- [ ] No unnecessary re-renders / rebuilds
- [ ] List rendering optimised
- [ ] No large imports
- [ ] Images optimised
### Platform Conventions
- [ ] Touch targets >= 44pt iOS / 48dp Android
- [ ] Safe area handling correct
- [ ] Platform-specific navigation patterns respected
- [ ] Deep link handling for new routes
### Accessibility
- [ ] Interactive elements have accessibility labels
- [ ] Error messages announced
- [ ] Focus order logical
- [ ] Color contrast WCAG AA
### Testing
- [ ] Unit tests for business logic
- [ ] Component tests for UI
- [ ] Edge cases covered
### Maintainability
- [ ] No duplicated logic (textual or semantic) whose sites change together for the same reason — unified, not copy-pasted
- [ ] Existing shared components/utils/RPCs/views reused, not re-implemented
- [ ] No speculative abstraction / dead flexibility (simplicity-first)
- [ ] Design patterns consistent with codebase conventions; no misapplied pattern
- [ ] Reuse/refactor opportunities noted as advisories (non-blocking)
- [ ] NOT flagged: coincidental similarity with different responsibilities (wrong abstraction), dogmatic tiny-function/length gates
### Verdict: PASS / FAIL
Integration
- Stage 1A (REQUIREMENTS.md) must pass before Stage 1B
- Stage 1B (PLAN.md) must pass before Stage 2
- Stage 2 failures get priority-ranked (P1/P2/P3) findings
- Only P1 findings block merge; P2/P3 are tracked
- All stages require fresh verification evidence
Verification
- Stage 1A checks every relevant F-x and UI-x from REQUIREMENTS.md
- Stage 1B checks every task in PLAN.md against implementation
- Stage 2 covers all items in the code quality checklist
- Findings are priority-ranked (P1/P2/P3)
- Only P1 findings block merge
References
- Used by:
commands/review-code.md
- Complements:
rules/quality-gates.md
- Consumes:
REQUIREMENTS.md, PLAN.md, PROGRESS.md
- Traceability:
skills/requirements-traceability.md