code-review

name	code-review
version	1.1.0
triggers	["review code","code review","review pr","review pull request","check architecture","architecture review","validate structure"]
languages	["typescript","javascript","ruby"]
categories	["code-quality","architecture","best-practices"]
dependencies	["typescript-clean-code"]
description	Systematic architecture-level code review for MindyCLI project

Code Review Skill

A systematic skill for conducting architecture-level code reviews on this project.

Overview

This skill orchestrates the full review process across four layers. It ensures consistency, quality, and adherence to project standards.

Key Distinction:

• This skill (code-review): Focuses on WHERE code lives and HOW it fits into the architecture
• Sub-skills (typescript-clean-code): Focus on HOW the code is written (naming, functions, SOLID, etc.)

Full architecture reference: references/architecture.md

Review Process

Step 1: Understand the Change

1. Read the commit message or PR description
2. Identify the files changed
3. Understand the purpose of the change

Step 2: Architecture Review

Check if the change follows the MVC-inspired CLI Architecture.

📖 See detailed architecture guidelines:

• MVC Architecture Reference - Full architecture diagram and layer responsibilities
• Architecture Checklist - Complete checklist with examples
• Cross-Platform Guide - Windows/macOS/Linux compatibility checks

Quick Architecture Check:

Layer	Directories	Responsibility
Controller	commands/, controllers/	User interaction, API communication
Model	services/, types/	Business logic, data structures
View	views/, templates/	Output formatting, prompt generation
Infrastructure	config/, data/, utils/	Cross-cutting concerns

Critical Questions:

• Is the code in the correct directory for its responsibility?
• Does it follow the dependency flow? (See Architecture Checklist)
• Is it cross-platform compatible? (See Cross-Platform Guide)

Step 3: Code Quality Review

Delegates to language-specific sub-skills:

• TypeScript/JavaScript → typescript-clean-code skill
• Ruby → Ruby style guide (future skill)

Skip when: architecture-only changes, documentation-only updates, or config-only changes.

Output: Report saved to skills/typescript-clean-code/reviews/<scope>-<date>-review.md

Step 4: Testing Review

• Tests exist for the new functionality?
• Existing tests still pass? (npm test in cli/)
• Tests use toContain() instead of exact path matching (cross-platform)?

Step 5: Documentation Review

• Code is self-documenting?
• IMPLEMENTATION_PLAN.md updated if needed?
• Directives updated if behavior changed?

Output Format

After review, produce a report in this format:

## Code Review Report

**Date:** YYYY-MM-DD
**Reviewer:** [Name/Agent]
**Files Reviewed:** [List of files]

### Summary
[Brief overview of changes]

### Findings

#### Strengths
- [What was done well]

#### Suggestions
- [Optional improvements]

#### Issues (Must Fix)
- [Critical problems]

### Verdict
- [ ] Approved
- [ ] Approved with suggestions
- [ ] Needs changes

Examples

Example 1: Reviewing a Service File

Reference Documentation

• MVC Architecture - Complete architecture overview
• Architecture Checklist - Detailed review checklist
• Cross-Platform Guide - Platform compatibility guidelines
• CLI Structure Diagram - Visual architecture reference

Example Usage

Actions:

1. Confirm file is in services/ (Model layer — architecture compliant)
2. Delegate to typescript-clean-code skill for quality review
3. Verify cross-platform path handling (path.join() + process.platform)
4. Confirm test exists (library-scanner.test.ts)
5. Check documentation completeness

Result: Code Review Report — Verdict: Approved

---

Example 2: Reviewing a New Command Before Merge

User: "Review the new library.ts command before I merge."

Actions:

1. Confirm file is in commands/ (Controller layer)
2. Business logic delegated to library-scanner.ts service
3. Output routed through library-result.ts view
4. Types imported from types/library-info.ts
5. Command-level tests missing

Result: Code Review Report — Verdict: Approved with suggestions (add command-level tests)

Integration with Other Skills

Skill	When to Use
typescript-clean-code	TS/JS code quality review
(future) ruby-clean-code	Ruby API code
(future) testing	Test quality review