Skip to main content

samba-e2e-rebase

Rebase E2E test snapshots based on failed tests from the PR comments.

Ir a la instalación

Datos de origen

Repositorio
criptogus/Samba-Builder
Última actividad en el origen
8 de septiembre de 2026 a las 15:30
Idioma detectado de SKILL.md
inglés
Estrellas
1
Forks
0

Opciones de instalación

De forma predeterminada está seleccionado el prompt que primero revisa el origen. Puedes cambiar a un comando directo o descargar una copia local.

Revisa los archivos de origen

Lee SKILL.md y los archivos complementarios que muestra SkillsMP antes de decidir si quieres instalarlo.

Mostrando SKILL.md

SKILL.md
Instrucciones de origen · Vista previa de solo lectura
name
samba:e2e-rebase
description
Rebase E2E test snapshots based on failed tests from the PR comments.
# E2E Snapshot Rebase Rebase E2E test snapshots based on failed tests from the PR comments. ## Instructions 1. Get the current PR number using `gh pr view --json number --jq '.number'` 2. Fetch PR comments and look for the Playwright test results comment. Parse out the failed test filenames from either: - The "Failed Tests" section (lines starting with `- \`filename.spec.ts`) - The "Update Snapshot Commands" section (contains `npm run e2e e2e-tests/filename.spec.ts`) 3. If no failed tests are found in the PR comments, inform the user and stop. 4. **Build the application binary:** ``` npm run build ``` **IMPORTANT:** E2E tests run against the built binary. If any application code (anything outside of `e2e-tests/`) has changed, you MUST run this build step before running E2E tests, otherwise you'll be testing the old version. 5. For each failed test file, run the e2e test with snapshot update: ``` PLAYWRIGHT_HTML_OPEN=never npm run e2e e2e-tests/<testFilename>.spec.ts -- --update-snapshots ``` 6. After updating snapshots, re-run the same tests WITHOUT `--update-snapshots` to verify they pass consistently: ``` PLAYWRIGHT_HTML_OPEN=never npm run e2e e2e-tests/<testFilename>.spec.ts ``` If any test fails on this verification run, inform the user that the snapshots may be flaky and stop. 7. Show the user which snapshots were updated using `git diff` on the snapshot files. 8. Review the snapshot changes to ensure they look reasonable and are consistent with the PR's purpose. Consider: - Do the changes align with what the PR is trying to accomplish? - Are there any unexpected or suspicious changes? 9. If the snapshots look reasonable, commit and push the changes: ``` git add e2e-tests/snapshots/ git commit -m "Update E2E snapshots" git push ``` 10. Inform the user that the snapshots have been updated and pushed to the PR.
Ver en GitHub