finish-feature

name	finish-feature
description	Run the api-colombia feature-completion checklist: add/extend tests, run dotnet test, bump the version (semver), and update the CHANGELOG plus docs and README when public behavior changed. Use when finishing a new feature or an important change, or when the user says a change is "done" / "ready" and wants it properly tested, versioned, and documented before committing.

Finish Feature — closing checklist

Use this after implementing a new feature or an important change in api-colombia, before committing. Work through the steps in order. Don't skip a step silently — if one doesn't apply, say so briefly and move on.

0. Understand what changed

• Run git status and git diff (and git diff --staged) to see the actual change and its scope.
• State in one or two sentences what behavior changed and whether it is user-facing (new/changed endpoint, response shape, limit, header) or internal-only (refactor, tooling). This drives how much of steps 4–5 apply.

1. Tests

Follow the repo conventions (see CLAUDE.md → "When adding or changing an endpoint", step 5). Tests live in api.Tests/.

• Add or extend tests that exercise the new behavior end-to-end. Integration tests use CustomWebApplicationFactory (api.Tests/ApiRoutesTests/).
• Cover the happy path and the notable edge cases / failure modes of what you changed.
• Isolation gotcha: each test class shares one WebApplicationFactory instance. If a test needs a lot of requests or its own app state (e.g. exhausting a rate limit), put it in its own test class so it gets its own factory instance and doesn't contaminate other tests. (See ResourceRateLimitTests / for the pattern.)