xianwen-code-review

name	xianwen-code-review
description	Deep code review for Xianwen Online against design documents. Multi-round review with separate frontend/backend analysis, gap detection, and issue tracking. Use when user asks for 'code review', '審查', '檢查', or wants to verify implementation matches design.

Xianwen Deep Code Review

Multi-round review workflow verified across 10+ review sessions.

Review Scope

Against Design Documents

Primary reference: docs/redesign/ directory

• Compare each design requirement against actual implementation
• Flag missing features, partial implementations, and deviations
• Check both backend services AND frontend components

Review Output

Write findings to docs/reviews/ with naming convention:

• backend-deep-review-YYYY-MM-DD.md
• frontend-deep-review-YYYY-MM-DD.md

Review Process

Round 1: Gap Analysis

Use parallel agents for frontend and backend:

Backend Agent:

1. Read each design doc in docs/redesign/
2. For each requirement, grep the corresponding service/handler
3. Flag: MISSING (not implemented), PARTIAL (incomplete), DEVIATION (different from spec)
4. Check database schema matches design

Frontend Agent:

1. Read each design doc's UI requirements
2. Check corresponding Vue components exist and are functional
3. Verify store integration and API calls
4. Check responsive design (mobile/tablet/desktop)

Round 2-N: Fix & Re-review

After fixes are applied:

1. Re-run the review focusing on previously flagged items
2. Look for regressions introduced by fixes
3. Rate issues by severity: CRITICAL > HIGH > MEDIUM > LOW

Severity Definitions

Level	Definition	Action
CRITICAL	Feature completely broken or missing	Fix immediately
HIGH	Feature partially working, major UX impact	Fix before deploy
MEDIUM	Minor issues, workarounds exist	Fix when possible
LOW	Polish/optimization items	Track for later

Key Review Checklist

Backend

• All API endpoints return correct data structure
• WebSocket messages properly broadcast
• Database queries use parameterized SQL (no injection)
• Error handling provides useful messages
• No panic/unwrap in production code paths
• Connection pool properly configured
• Intent engine handles edge cases

Frontend

• All dialogs/panels have proper open/close lifecycle
• WebSocket reconnection preserves state
• Loading states shown during API calls (防抖動)
• Mobile responsive (<=480px touch targets 44px)
• Image assets correctly mapped
• i18n keys exist for all user-facing text
• No hardcoded colors (use design tokens from tokens.css)

Cross-cutting

• Types match between frontend and backend
• New features have HUD entry points
• Database migrations exist for schema changes
• No unused imports or dead code

Review Report Format

# [Backend/Frontend] Review - YYYY-MM-DD

## Summary
- Total issues: X
- Critical: X | High: X | Medium: X | Low: X

## Issues

### [CRITICAL] Issue title
- **Location**: file:line
- **Design ref**: docs/redesign/xxx.md section Y
- **Expected**: What the design says
- **Actual**: What the code does
- **Fix**: Suggested fix