review-config-backcompat

Étoiles6 105

Forks1 487

Mis à jour12 mai 2026 à 21:26

Review Apache Pinot diffs for configuration and backward-compatibility risks. Covers config key renames, SPI signature changes, schema/enum additions, feature-flag defaults, multi-level config override validation, rolling-upgrade safety, REST/JSON/Protobuf field evolution, and segment/DataTable format versioning. Trigger keywords — config key, config rename, SPI, feature flag, enum, schema type, DataTable version, segment version, Protobuf, Thrift, REST endpoint, @Deprecated, mixed-version, rolling upgrade, ZooKeeper schema.

Installation

Installer avec Codex ou Claude Copiez ce prompt, collez-le dans Codex, Claude ou un autre assistant, puis laissez-le vérifier la page du skill et l'installer pour vous.

Exécuter dans Manus

Source

apache

apache/pinot

Ouvrir le dépôt GitHub Voir les dépôts du créateur

Téléchargement

Exécuter dans Manus

Métiers associésSOC

Basé sur la classification professionnelle SOC

Développeurs de logicielsProfessions informatiques et mathématiques·SOC 15-1252

SKILL.md

readonly

name	review-config-backcompat
description	Review Apache Pinot diffs for configuration and backward-compatibility risks. Covers config key renames, SPI signature changes, schema/enum additions, feature-flag defaults, multi-level config override validation, rolling-upgrade safety, REST/JSON/Protobuf field evolution, and segment/DataTable format versioning. Trigger keywords — config key, config rename, SPI, feature flag, enum, schema type, DataTable version, segment version, Protobuf, Thrift, REST endpoint, @Deprecated, mixed-version, rolling upgrade, ZooKeeper schema.
domain	kb/code-review-principles.md#1-configuration--backward-compatibility
triggers	["diff touches config constants (ConfigConstants.java, Config.java)","diff modifies pinot-spi/ or pinot-segment-spi/ interfaces","diff adds or renames enum values / schema DataType / FieldSpec.DataType","diff touches .proto / .thrift / DataTableBuilder / DataTableUtils","diff adds a new REST resource or JSON field in a REST response","diff touches TableConfig / Schema / InstanceConfig JSON-serializable fields"]
license	Apache-2.0

Skill: review-config-backcompat

Procedure: see kb/skills/review-config-backcompat.md. Read it first, then follow it.

Plus depuis ce dépôt

même dépôt

bench-compare

apache/pinot

Run a Pinot JMH benchmark twice — once on a baseline commit, once with the current changes — and report both sets of results side by side. Uses a git worktree so the user's working tree is never disturbed.

2026-05-126.1k

flaky-analyze

apache/pinot

Pull recent GitHub Actions failures for a Pinot test class and analyze whether they share a root cause. Uses the gh CLI. Surfaces stack traces, failure patterns, and a candidate hypothesis — does not auto-fix.

2026-05-126.1k

precommit

apache/pinot

Run Pinot's mandatory pre-commit checks (spotless, license, checkstyle) and compiler warning checks on only the modules affected by the current diff. Auto-fixes what it can, reports what it can't.

2026-05-126.1k

quickstart

apache/pinot

Launch a local Pinot quickstart cluster (batch, hybrid, streaming, upsert, etc.) with the right script, building the binary distribution first if needed.

2026-05-126.1k

review-architecture

apache/pinot

Review Apache Pinot diffs for architectural concerns — module boundaries, SPI vs. impl separation, circular deps, misplaced logic (broker code in server, server code in controller), abstraction choice (interface vs. abstract class), plugin layering, and layering violations between pinot-spi / pinot-common / pinot-core / pinot-segment-spi / pinot-segment-local. Trigger keywords — new interface, abstract class, package move, module, SPI, broker-server boundary, plugin, shaded.

2026-05-126.1k

review-concurrency-state

apache/pinot

Review Apache Pinot diffs for concurrency, state management, visibility, atomic state transitions, lock changes, Helix IdealState updates, upsert metadata safety, consumer/stream ingestion races, and shared-observer correctness. Trigger keywords — synchronized, volatile, AtomicReference, ConcurrentHashMap, ReentrantLock, StampedLock, Helix, IdealState, ZkClient, version-checked write, upsert metadata, consumer coordinator, stream partition.

2026-05-126.1k

name	review-config-backcompat
description	Review Apache Pinot diffs for configuration and backward-compatibility risks. Covers config key renames, SPI signature changes, schema/enum additions, feature-flag defaults, multi-level config override validation, rolling-upgrade safety, REST/JSON/Protobuf field evolution, and segment/DataTable format versioning. Trigger keywords — config key, config rename, SPI, feature flag, enum, schema type, DataTable version, segment version, Protobuf, Thrift, REST endpoint, @Deprecated, mixed-version, rolling upgrade, ZooKeeper schema.
domain	kb/code-review-principles.md#1-configuration--backward-compatibility
triggers	["diff touches config constants (ConfigConstants.java, Config.java)","diff modifies pinot-spi/ or pinot-segment-spi/ interfaces","diff adds or renames enum values / schema DataType / FieldSpec.DataType","diff touches .proto / .thrift / DataTableBuilder / DataTableUtils","diff adds a new REST resource or JSON field in a REST response","diff touches TableConfig / Schema / InstanceConfig JSON-serializable fields"]
license	Apache-2.0

Skill: review-config-backcompat

Procedure: see kb/skills/review-config-backcompat.md. Read it first, then follow it.