Skip to main content

reviewing-vsintegration

Routes a Visual Studio integration or compiler-service review to the file for that tree. Use when reviewing a PR, pre-merge change, or edit under vsintegration, FSharp.Editor, the legacy language service, FSI, the project system, MEF, src/Compiler/Service, src/Compiler/Symbols, FCS snapshots, the incremental builder, workspace, navigation, completion, or symbols. Invokes @ide-integration. Does not review compiler type checking, IL, pickle, or FSharp.Core.

Informations de source

Dépôt
dotnet/fsharp
Dernière activité de la source
16 octobre 2026 à 10:13
Langue détectée de SKILL.md
anglais
Étoiles
4 348
Forks
883

Options d'installation

Le prompt qui vérifie d'abord la source est sélectionné par défaut. Vous pouvez passer à une commande directe ou télécharger une copie locale.

Vérifiez les fichiers source

Lisez SKILL.md et les fichiers associés affichés par SkillsMP avant de décider de l'installer.

Explorateur de fichiers
3 fichiers

Affichage de SKILL.md

SKILL.md
Instructions source · Aperçu en lecture seule
name
reviewing-vsintegration
description
Routes a Visual Studio integration or compiler-service review to the file for that tree. Use when reviewing a PR, pre-merge change, or edit under vsintegration, FSharp.Editor, the legacy language service, FSI, the project system, MEF, src/Compiler/Service, src/Compiler/Symbols, FCS snapshots, the incremental builder, workspace, navigation, completion, or symbols. Invokes @ide-integration. Does not review compiler type checking, IL, pickle, or FSharp.Core.
# Reviewing VS integration Tree checks live in `vsintegration.md` and `compiler-service.md`; the three boundary checks live in `@ide-integration`. `@expert-reviewer` stays the compiler reviewer. Do not send `vsintegration` or `src/Compiler/Service` findings there. ## Which file | Diff touches | Read | |---|---| | `vsintegration/**` | [vsintegration.md](vsintegration.md) | | `src/Compiler/Service/**` or `src/Compiler/Symbols/**` | [compiler-service.md](compiler-service.md) | | Both | Both files | | `vsintegration/tests/**` | [vsintegration.md](vsintegration.md) | | `tests/FSharp.Compiler.Service.Tests/**` | [compiler-service.md](compiler-service.md) | Use the Both trees rules only when the diff touches both trees or adds a reference from `src/Compiler/Service` to `vsintegration`. ## Folder routing | Path | File | Select | |---|---|---| | `vsintegration/src/FSharp.Editor/**` | vsintegration.md | UI thread, MEF, caches, quick info, navigation, completion, diagnostics, options, classification | | `vsintegration/src/FSharp.LanguageService/**` | vsintegration.md | Legacy language service, UI thread, solution lifetime | | `vsintegration/src/FSharp.ProjectSystem*/**` | vsintegration.md | Project lifetime, UI thread, generator identity | | `vsintegration/src/FSharp.VS.FSI/**` | vsintegration.md | Interactive session startup and cancellation | | `vsintegration/tests/**` | vsintegration.md | Editor tests must call the host provider | | `vsintegration/**` other | vsintegration.md | Do not push host types into the compiler service | | `src/Compiler/Service/**` | compiler-service.md | Cache identity, incremental results, locks, public FCS API, diagnostics, readers | | `src/Compiler/Symbols/**` | compiler-service.md | Symbol results, ranges, completion, walks | | `tests/FSharp.Compiler.Service.Tests/**` | compiler-service.md | Assert the observable service result. Isolate process-wide state | ## Do not route here - `src/Compiler/Checking/`, `src/Compiler/Optimize/`, `src/Compiler/CodeGen/`, `src/Compiler/TypedTree/`, `src/Compiler/SyntaxTree/`, `src/Compiler/Driver/` - `src/FSharp.Core/**` - `src/FSharp.Compiler.LanguageServer/**` is not this corpus. Compiler concurrency stays with `@expert-reviewer`.
Voir sur GitHub