visual

# Visual review Judge each screenshot that differed from its baseline in the last visual run. Only report. Never update baselines, edit files, or touch ../riffle. ## 1. Collect the diffs - Each failed screenshot has a folder in `test-results/` with three images: `<name>-expected.png` (the baseline), `<name>-actual.png` (this run) and `<name>-diff.png` (changed pixels in red). - The folder name holds the test name. - If there are no such folders, say the visual run passed and stop. - Look at all three images for every diff. The diff image shows where to look, and expected against actual shows what changed. ## 2. Find the cause in riffle - Run `git -C ../riffle status --short` and `git -C ../riffle diff` to see uncommitted riffle changes, and `git -C ../riffle log -5 --stat` for recent commits. - Match each visual change to the code change that explains it, usually CSS or JSX near the affected element. - The same change often shows up in several screenshots. Judge it once and list where it appears. ## 3. Classify each change - **Intended**: a code change explains it and the result looks deliberate and correct, such as a restyled button or new spacing. - **Regression**: something looks broken or unintended. Examples are overlapping or clipped text, a missing element, a photo grid that didn't lay out, or a change no code change explains. - **Noise**: a tiny difference with no visible meaning, such as a one-pixel shift or anti-aliasing. Noise means the screenshot isn't deterministic, so name what varies. riffle is dark-only, so check contrast against the dark background. When unsure between intended and regression, call it a regression and say why. ## 4. Report One entry per distinct change: - what changed, in one sentence - the screenshots it affects, by name - the verdict (intended, regression or noise), with the code change or reason behind it End with one line of advice: - all intended: run `make visual-update` to accept the new baselines. - any regression: fix riffle first, and don't update the baselines. - any noise: make that screenshot deterministic in `visual/` before updating.