reviewing-changes

name

reviewing-changes

description

Performs comprehensive code reviews for Bitwarden iOS projects, verifying architecture compliance, style guidelines, compilation safety, test coverage, and security requirements. Use when reviewing pull requests, checking commits, analyzing code changes, verifying Bitwarden coding standards, evaluating unidirectional data flow pattern, checking services container dependency injection usage, reviewing security implementations, or assessing test coverage. Automatically invoked by CI pipeline or manually for interactive code reviews.

Reviewing Changes — Bitwarden iOS

Instructions

Work systematically through each step before providing feedback. Each checklist loads only the relevant review strategy for the change type detected.

Step 1: Retrieve Additional Details

Fetch any additional context using available tools (JIRA MCP, GitHub API). If the PR title and description don't provide enough context, request:

• A link to the JIRA ticket
• A GitHub issue reference
• More detail in the PR description

iOS-specific metadata checks:

• Screenshots required for any *View.swift changes that affect visible UI — flag as ❓ if absent
• If new *Processor.swift or *Service.swift is added with no test file, flag as ❓

Step 2: Detect Change Type

iOS-specific patterns:

• Feature Addition: New *Coordinator.swift, *Processor.swift, *View.swift (full file-set); new screen or flow
• Bug Fix: Targeted changes to existing *Processor.swift, *Service.swift, or *Repository.swift files
• UI Change: Changes only to files; no business logic changes