메뉴
Repo-specific guidance for reviewing pull requests on hifiberry-os. Use this whenever reviewing a pull request or diff in this repository.
기본적으로 소스를 먼저 확인하는 Prompt가 선택됩니다. 직접 명령으로 전환하거나 로컬 사본을 다운로드할 수도 있습니다.
설치 여부를 결정하기 전에 SKILL.md와 SkillsMP에 표시된 보조 파일을 읽어 보세요.
Codex 또는 Claude로 설치 이 Prompt를 복사해 Codex, Claude 또는 다른 어시스턴트에 붙여 넣으면 Skill 페이지를 검토하고 설치를 진행할 수 있습니다.
직접 명령은 검토 Prompt를 거치지 않습니다. 실행하기 전에 소스를 확인하세요.
npx skills add https://github.com/hifiberry/hifiberry-os --skill code-review명령은 한 줄로 유지됩니다. 복사하기 전에 가로로 스크롤해 전체 내용을 확인하세요.
로컬 사본을 원하시나요? SkillsMP에서 현재 제공할 수 있는 파일을 다운로드하세요.
SKILL.md 표시 중
SOC 직업 분류 기준
| name | code-review |
| description | Repo-specific guidance for reviewing pull requests on hifiberry-os. Use this whenever reviewing a pull request or diff in this repository. |
hifiberry-os is a collection of Debian packages plus the scripts that build,
check, and publish them. Most changes fall into one of: a package under
packages/<name>/, a top-level shell script, or CI/tooling. Review with that
in mind rather than as a generic application codebase.
packages/*)Every package pulls its sources either as a git submodule or via a clone made
by its own build.sh — never both for the same path. When a diff touches a
package, check for the failure modes scripts/check-packages.py is designed
to catch:
.gitmodules.build.sh clone target.build.sh clone target that isn't covered by .gitignore — this is one
git add . away from committing a whole upstream source tree.debian/changelog that doesn't match the version in
the package's own manifest (e.g. setup.py, package.json, Cargo.toml).If the PR run of the packages consistency workflow
(.github/workflows/check-packages.yml, runs check-packages.py) is
available via the GitHub MCP server, check its result rather than
re-deriving these checks by hand.
Top-level scripts (addrepo, install-all, upgrade-to-trixie,
packages/*/build.sh, etc.) are curl-piped-to-bash or run unattended on
embedded devices. Flag:
set -e (or equivalent) where a failed step should abort instead
of continuing silently.rm -rf, package purges, partition/flash operations)
that aren't guarded or don't fail loudly.Nothing in this repo should reference private hostnames, IPs, credentials, or tokens for the build/publish pipeline (aptly, the debianrepo host, SSH keys). If a diff adds any, flag it regardless of how it's framed.
Keep review comments proportional to the diff: a .gitignore or docs-only
change doesn't need packaging/shell scrutiny, and a one-line version bump
doesn't need a design discussion.