| name | project-plan-review |
| description | Review checklist for project plans before execution. Includes structural validation, container/VM requirements, cross-reference checks, and performance considerations. |
Project Plan Review
Use when editing or reviewing project plans in docs/projects/ to ensure completeness, correctness, and prevent common planning mistakes.
Rules
- ALWAYS verify dynamic group persistence for separate ansible-playbook invocations
- ALWAYS document auth transitions with ordering, re-registration, detection
- NEVER split provisioning and site.yml integration into separate milestones
- NEVER use
proxmox_lxc_default_template - create service-specific template vars
- NEVER add "graceful skip" for expected hardware - hard-fail instead
- ALWAYS verify container IP offset doesn't collide with existing allocations
- NEVER use bare relative paths - they break with molecule scenarios
- ALWAYS include rollback plays in
playbooks/cleanup.yml for all features
Patterns
Structural validation:
- name: Reconstruct dynamic group for rollback
include_tasks: tasks/reconstruct_service_group.yml
Cross-reference verification:
- grep for VMID in group_vars/all.yml
- grep for flavor group in inventory/hosts.yml
- grep for platform in molecule/*/molecule.yml
- grep for cleanup in both cleanup playbooks
- grep for verify assertions in molecule/default/verify.yml
Container IP allocation check:
Anti-patterns
NEVER explain what project plans are in review rules
NEVER keep blocked milestones as stubs in current project
NEVER omit LXC features declaration (nesting=1, privileged, etc.)
NEVER skip image build milestone - configure roles can't install packages