Skip to main content

mz-feature-flags

Trigger: adding or changing a feature flag, dyncfg, or system parameter default, reviewing a PR that adds one, LaunchDarkly flag setup, or bin/lint-test-flags failures in Materialize.

소스 정보

저장소
MaterializeInc/materialize
최근 소스 활동
2026년 10월 23일 16:11
감지된 SKILL.md 언어
영어
스타
6,388
포크
516

설치 방법

기본적으로 소스를 먼저 확인하는 Prompt가 선택됩니다. 직접 명령으로 전환하거나 로컬 사본을 다운로드할 수도 있습니다.

소스 파일 검토

설치 여부를 결정하기 전에 SKILL.md와 SkillsMP에 표시된 보조 파일을 읽어 보세요.

SKILL.md 표시 중

SKILL.md
소스 지침 · 읽기 전용 미리보기
name
mz-feature-flags
description
Trigger: adding or changing a feature flag, dyncfg, or system parameter default, reviewing a PR that adds one, LaunchDarkly flag setup, or bin/lint-test-flags failures in Materialize.
# Feature flags Choosing whether a new feature flag defaults on or off in production is a product decision that needs context an agent rarely has. When adding a flag, ask a human which default to use. When reviewing a PR, do not question the default it chose. However, in tests, a new flag should usually be on, so that sqllogictest and testdrive exercise the new code path. If its production default is off, turn it on for CI in `misc/python/materialize/mzcompose/__init__.py` (`get_minimal_system_parameters` if tests fail with it off, otherwise `get_variable_system_parameters`), which `bin/sqllogictest` and mzcompose's `Materialized` service pass to environmentd as system parameter defaults. Rust integration tests use `TestHarness::with_system_parameter_default`. A value listed there overrides the compiled-in default in CI, so changing a default means changing both. `bin/lint-test-flags` fails unless every new dyncfg is registered for parallel workload and mzcompose (see the mz-debug-ci skill). A compiled-in default is not evidence of the production value: check whether `test/launchdarkly-flag-consistency/mzcompose.py` lists the flag in `INTENTIONAL_LD_OVERRIDES` or `KNOWN_CROSS_ENV_DIVERGENCES`. A session variable takes a system default only if `SESSION_SYSTEM_VARS` in `src/sql/src/session/vars.rs` lists it. Otherwise `--system-parameter-default` for it only logs a warning at startup. Observed: the LaunchDarkly MCP `create-flag` tool creates boolean flags that serve true in every environment, including production. A human must set each environment's off variation and fallthrough to false.
GitHub에서 보기