sapcc-review

name	sapcc-review
description	Gold-standard SAP CC Go code review: 10 parallel domain specialists.
user-invocable	false
argument-hint	[--fix]
command	/sapcc-review
agent	golang-general-engineer
allowed-tools	["Agent","Read","Write","Bash","Grep","Glob","Edit","TaskCreate","TaskUpdate","TaskList","EnterWorktree"]
routing	{"not_for":"full-repo compliance audit scan (use sapcc-audit). This skill is deep 10-specialist parallel review.","triggers":["sapcc review","sapcc lead review","sapcc compliance review","full sapcc check","review sapcc standards"],"pairs_with":["golang-general-engineer","go-patterns","sapcc-audit"],"force_route":false,"complexity":"Complex","category":"language"}

SAPCC Comprehensive Code Review v1

10-agent domain-specialist review. Each agent masters one rule domain and scans every package for violations against the comprehensive patterns reference.

How this differs from /sapcc-audit: sapcc-audit segments by package (generalist per package). sapcc-review segments by rule domain (specialist per concern, cross-package). Both are useful; this one catches more because specialists find issues generalists miss.

---

Overview

This skill executes a gold-standard code review against SAP Converged Cloud Go repository standards through parallel domain specialists. Rather than one generalist reviewing one package, ten specialists review all packages for their specific domain (error handling, testing, types, HTTP APIs, etc.). This catches systemic patterns that package-level reviews miss.

Each specialist loads only its domain-specific reference file to keep context tight and focus deep. Findings are code-level (actual rejected/correct examples, never abstract suggestions) and cite specific sections from sapcc-code-patterns.md.

---

Reference Loading Table

Signal	Load These Files	Why
Phase 2 DISPATCH: the 10 domain-specialist prompts	agent-dispatch-prompts.md	Loads detailed guidance from agent-dispatch-prompts.md.
Phase 3 AGGREGATE: report structure and severity boosts	report-template.md	Loads detailed guidance from report-template.md.

Instructions

Phase 1: DISCOVER

Goal: Map the repository, verify it's an sapcc project, plan the review.

Step 1: Verify sapcc project

cat go.mod | head -5
grep -c "sapcc" go.mod

If the module path doesn't contain "sapcc" AND go.mod doesn't import any sapcc packages, warn the user but continue (they may want to check a non-sapcc repo against the project's standards).

Step 2: Map all Go packages and files

# Count .go files (excluding vendor)
find . -name "*.go" -not -path "*/vendor/*" | wc -l


find . -name  -not -path  | sed  |  |  -c |  -rn


find . -name  -not -path  |  -l