원클릭으로 Manus에서 모든 스킬 실행

vime-code-review-preferences

스타370

포크60

업데이트2026년 6월 29일 04:03

Use when reviewing or editing vime code, especially refactors around helper APIs, branch selection, argument validation, or recurring reviewer preferences about avoiding unnecessary wrappers and making control flow self-explanatory.

설치

Codex 또는 Claude로 설치 이 Prompt를 복사해 Codex, Claude 또는 다른 어시스턴트에 붙여 넣으면 Skill 페이지를 검토하고 설치를 진행할 수 있습니다.

Manus에서 실행

출처

vllm-project

vllm-project/vime

GitHub 저장소 열기 Creator 저장소 보기

다운로드

Manus에서 실행

Vime Code Review Preferences

Apply these lightweight review heuristics when changing vime code.

Prefer Direct APIs Over Thin Wrappers

Remove helper layers that only rename a call, format one path, or forward arguments without owning meaningful behavior.
Prefer calling the concrete reusable API directly, for example a *_to_path helper when the caller already knows the destination path.
Keep a wrapper only if it owns a real boundary: compatibility, validation, nontrivial error policy, lifecycle management, metrics/logging semantics, async/retry behavior, or cross-module ownership.
Avoid moving a redundant wrapper's body into another file just to preserve the wrapper shape. Inline the simple call at the natural ownership site.
When removing a wrapper, search for sibling wrappers and nearby helpers with rg and delete confirmed dead functions in the same pass.
Treat single-use convenience functions as suspicious when their only job is path formatting plus forwarding. Prefer the caller owning that one line.

Make Branches Explain Themselves

Order conditionals by semantic precedence: special transport/lifecycle modes first, then explicit mode choices, then default paths.
Prefer predicates that fully describe the branch, such as mode == "full" and transport == "disk", over a broad predicate followed by an assert that explains what the branch really meant.
Use asserts as invariants for impossible states after validation, not as a substitute for clear branch conditions.

Keep Abstractions Honest

Add an abstraction only when it removes real duplication, hides fragile mechanics, or clarifies ownership.
When a review comment points out repeated indirection, look for a smaller public surface rather than adding another alias.
Preserve existing behavior intentionally. If cleanup changes error handling, logging, or failure visibility, call that out in the final response.

이 저장소의 다른 Skills

같은 저장소

add-tests-and-ci

vllm-project/vime

Guide for adding or updating vime tests and CI wiring. Use when tasks require new test cases, CI registration, test matrix updates, or workflow template changes.

2026-06-29370

add-dynamic-filter

vllm-project/vime

Guide for adding dynamic/filter hooks in vime rollout pipeline. Use when user wants sample-group selection during rollout, buffer filtering before training, or per-sample masking/processing hooks.

2026-06-04370

add-eval-dataset-config

vllm-project/vime

Guide for adding and validating evaluation dataset configuration in vime. Use when user wants to configure eval datasets via --eval-config or --eval-prompt-data, add per-dataset overrides, or customize evaluation rollout behavior.

2026-06-04370

add-reward-function

vllm-project/vime

Guide for adding a custom reward function in vime and wiring it through --custom-rm-path (and optional reward post-processing). Use when user wants new reward logic, remote/service reward integration, or task-specific reward shaping.

2026-06-04370

add-rollout-function

vllm-project/vime

Guide for adding a new rollout function in vime and wiring it through --rollout-function-path. Use when user wants to implement custom rollout data generation logic, custom train/eval rollout outputs, or migrate from the default vLLM rollout path.

2026-06-04370

name	vime-code-review-preferences
description	Use when reviewing or editing vime code, especially refactors around helper APIs, branch selection, argument validation, or recurring reviewer preferences about avoiding unnecessary wrappers and making control flow self-explanatory.

Vime Code Review Preferences

Apply these lightweight review heuristics when changing vime code.

Prefer Direct APIs Over Thin Wrappers

Remove helper layers that only rename a call, format one path, or forward arguments without owning meaningful behavior.
Prefer calling the concrete reusable API directly, for example a *_to_path helper when the caller already knows the destination path.
Keep a wrapper only if it owns a real boundary: compatibility, validation, nontrivial error policy, lifecycle management, metrics/logging semantics, async/retry behavior, or cross-module ownership.
Avoid moving a redundant wrapper's body into another file just to preserve the wrapper shape. Inline the simple call at the natural ownership site.
When removing a wrapper, search for sibling wrappers and nearby helpers with rg and delete confirmed dead functions in the same pass.
Treat single-use convenience functions as suspicious when their only job is path formatting plus forwarding. Prefer the caller owning that one line.

Make Branches Explain Themselves

Order conditionals by semantic precedence: special transport/lifecycle modes first, then explicit mode choices, then default paths.
Prefer predicates that fully describe the branch, such as mode == "full" and transport == "disk", over a broad predicate followed by an assert that explains what the branch really meant.
Use asserts as invariants for impossible states after validation, not as a substitute for clear branch conditions.

Keep Abstractions Honest

Add an abstraction only when it removes real duplication, hides fragile mechanics, or clarifies ownership.
When a review comment points out repeated indirection, look for a smaller public surface rather than adding another alias.
Preserve existing behavior intentionally. If cleanup changes error handling, logging, or failure visibility, call that out in the final response.