loopx-pr-review

# LoopX PR Review This skill is a thin host adapter. The built-in `pull-request-review` capability owns review depth, evidence requirements, completeness, and verdict policy through the CLI packet. Do not copy those rules into this skill or replace them with a host-specific checklist. ## Route Use this skill for `/loopx-pr-review`, explicit PR reviews, or review queues by state or time window. Route approval, merge, self-merge, and admin bypass to `loopx-pr-merge` (optional repo-kept workflow, not installed by default) after the evidence review is complete; it never replaces this skill's exact-head gate. For named PRs, resolve heads and run repeatable `--target-exact-head NUMBER@HEAD_OID`. An omitted `--state` keeps ordinary queue discovery open-only while exact targets remain lifecycle-neutral; use explicit `--state merged|all` only for deliberate history or post-merge audit. Translate only explicit filters: - `--repo owner/repo` - `--since ISO` - `--state open|merged|all` - `--limit N`; `--target-exact-head NUMBER@HEAD_OID` (repeatable direct read) - `--review-priority other-developers-first|owner-first` (default `other-developers-first`; use `owner-first` to opt into owner priority) When omitted, the CLI resolves `pull_request_review` from the standard machine capability editor; an absent namespace keeps the default `other-developers-first`. Words such as `today`, `open`, or `merged` are filters, not permission to return a table only; stats-only output needs an explicit opt-out such as `只统计` or `stats only`. ## Preserve The Packet Save the full first JSON packet before printing a compact projection. Keep all paths named by `agent_response_contract.required_packet_fields_to_preserve`: - `agent_response_contract.review_execution_contract` - `result_completeness`, `scheduling_policy`, `review_groups` - `pull_requests[review_action_kind!=null].review_plan` - `pull_requests[review_action_kind!=null].review_template` - `pull_requests[review_action_kind!=null].evidence_commands` Do not pipe the only copy through `jq`. When an exhaustive queue request has `result_completeness.complete=false`, rerun with its `recommended_limit` before reviewing; `limit_scope=exact_targets` is already complete for the named targets. Read `review_execution_contract.policy_revision` from the packet; require the result's `review_policy_revision` to equal it, never a literal this file pins. If missing or unequal, do not publish APPROVE; a conservative REQUEST_CHANGES is allowed only when it names the incompatible-policy gap. Do not retain expired temporary worktree overrides. Report incompatible policy rather than downgrading the review. ## Read The Review Frame First Read the PR's existing comments and cited documents first: a maintainer comment names the contract the change is judged against. - Review inside that frame; cite the document and check its rows, gates, or exit criteria one by one at the exact head, attaching each finding to its row. - Name unsatisfied rows as missing frame items with their own evidence; keep the declared boundary (preview versus promotion, milestone entry versus merge). - Publish the frame-aligned conclusion as a PR comment citing that guidance, since a published review body cannot be edited. ## Execute One Review Plan Receive pending current-session requests through `review_execution_contract.decision_procedure.establish_goal` before generic queue selection, including other agents sharing a GitHub account; task intake and claimed action authority are separate judgments. Resolve the selected requests with repeatable `--target-exact-head NUMBER@HEAD_OID`. Follow `scheduling_policy` and its ranked actionable `review_sequence`; explicit current-request PR selection may override ordering only, never `pull_requests[].review_action_kind` or exact-head idempotency. Generic `re-review`, `重新review`, and `复审` wording selects the named PR; it is not a force-refresh token. Todo/monitor prose may not select work. When `review_action_kind` is null, the row stays in `pull_requests` inventory but must not appear in `review_sequence`; its `review_plan` and `review_template` are null and `evidence_commands` is empty. Read the packet's actual no-action reason and read back the relevant lifecycle/draft state or conclusion once; null action does not imply an existing conclusion. If the caller is also the authorized author and its proposal is complete, mark Draft ready and read back its state and unchanged head, then regenerate the packet. Reserve Draft for unfinished author work with a concrete remaining implementation or integration step. Missing review or held CI/merge qualification does not require Draft. A reviewer alone has no authority to change another author's submission state or invent a review action. Run a fresh audit only when the user explicitly requests fresh evidence despite an existing conclusion, or supplies a concrete new concern; regenerate with `--fresh-audit-exact-head NUMBER@HEAD_OID`, then execute the complete current plan and never inherit the earlier approval. Fresh audit is not a Draft bypass. For every actionable PR: When the capability supplies `independent_review` and a null action, read back that submitted review and skip duplicate full review. Its source-bound coverage does not require this agent's bilingual body format, grant approval or merge authority, or clear blockers. Unknown provenance does not establish coverage. An explicitly authorized fresh audit uses the same exact-head override above. 1. Record the packet's exact head, then follow `review_execution_contract.decision_procedure`: the current goal and `problem_context` delivery judgment first, including on re-review, then `evidence_commands` and repository-native validation. 2. Fill `review_plan.result_template`; missing evidence stays `unverified`; never infer `verified` from metadata or CI. Execute repository-reuse, default-off, authority and real-path counterfactuals, not prose declarations. Fill `result.reviewer` per `review_execution_contract.reviewer_declaration`; open with its `body_marker` line. Read `problem_context.spec_basis`'s specification before the diff, plus any `repository_experience` advice. In `problem_context`, state adoption, rejection or irrelevance with current-head evidence; do not inherit a case verdict or treat context delivery as semantic application or demonstrated utility. 3. Apply `completion_gate` literally: save final Markdown in `review_body`, then check evidence and that exact body. Follow capability-owned floors and scope counterfactuals; prose cannot replace missing execution: ```bash loopx --format json pr-review --check-result review-result.json --packet review-packet.json ``` Fix contradictory verdicts, not evidence labels. It cannot verify evidence truth, architecture, freshness or a relabeled old result. 4. Publish the checked `review_body`; recheck after edits. Replace `result.review_body` with the remote readback and rerun `--check-result`; matching does not certify reasoning. 5. Re-read the remote head immediately before verdict and publication; restart evidence if it changed. Each PR needs independent evidence and a standalone card; a queue table is a preface only. For managed review, pass `--goal-id GOAL` and execute the packet's current `validation_matrix`: its `wait_for_ci`, `validation_source` and `failure_attribution` (including `evidence_scope`) own CI observation and failure judgment. With `wait_for_ci=false`, never fetch, poll or wait for CI. Keep review verdict and merge readiness separate; do not substitute CI metadata for decisive changed-invariant evidence. Configure one Goal with `configure-goal --goal-id GOAL --no-pr-review-wait-for-ci --execute`; clear with `--clear-pr-review-configuration --execute`. ## Publish And Read Back For an open PR, publish validated actionable findings by default unless the user requested local-only/dry-run output or the finding is private or security-sensitive. Use `review_execution_contract.verdict_policy` for formal `REQUEST_CHANGES`, `APPROVE`, author-owned `COMMENTED` fallbacks and post-merge audit publication. Publish the complete checked body using the policy's action and fallback title; non-blocking suggestions and merge holds are not automatically review blockers. Avoid duplicating an equivalent exact-head result. Build public text from the exact reviewed head; remove local paths, private context, raw logs, credentials and internal-only links. Read the published review back, verify state/body and return its URL. After APPROVE (incl. existing approval), execute `review_execution_contract.approval_closeout`; reconcile only verified obsolete blockers with owner/GitHub authority, preserving discussion and unresolved reviews. Merge routes through `loopx-pr-merge`; `APPROVE` is not merge authority; a public blocker belongs on the PR. Immediately before every merge, run `loopx --format json pr-review --goal-id GOAL --repo OWNER/REPO --check-merge-readiness NUMBER@HEAD_OID`; require `ready=true`. Its compact Goal observation suppresses only unchanged requalification; material change reopens it, admin bypass never overrides this gate, and author fallback needs user authority. ## Full PR Review And Bilingual Format Use each PR's current `review_template`, `reviewer_declaration` and `completion_gate.required_final_sections` to render a standalone full-PR review. The **详细中文评审** covers the entire PR in five sections (`动机`, `改动思路`, `具体改动`, `对主干的风险`, `我的整体评价`); a findings-only or blocker-only body is incomplete. Cover every changed surface and key symbols according to the current plan, not just the main finding. Open with the visible `body_marker` matching `result.reviewer`. The **英文简短结论** starts with `English verdict:` and the bare token `APPROVE` or `REQUEST_CHANGES`, followed by the head, finding and validation. Follow the packet's `problem_context` publication rule and body floors; verify the published body through the same check-result/readback loop above. For example, walkthrough or smoke-only PRs, execute the current plan's required `durable_smoke_value` evidence: its fields and rule own the shipped-value, existing-coverage, same-author batch, consolidation and repeat-offender judgment. Do not approve from a passing smoke or a public-safe artifact alone. ## Autonomous Queue For recurring observation, keep one ignored checkpoint and use `loopx --format json pr-review --repo owner/repo --state open --autonomous-observation --observation-state-file .local/pr-review-monitor.json` with the projected or handled exact-head flags when those durable receipts exist. Treat `candidate` as a preview, not a durable projection. Follow this order: durable Todo target-key readback -> `--projected-exact-head` -> exact-head review/comment readback -> `--handled-exact-head`. Never send the projection ACK before the Todo exists, or the handled ACK before readback at that head. Observation states remain literal; the checkpoint grants no authority. Stateless callers may use `--previous-observation-json` instead. ## Failure If `loopx pr-review` is unavailable, repair the LoopX install or use the intended checked-out CLI. Do not reconstruct the queue manually and call it a successful `/loopx-pr-review` run.