team-review

name	team-review
disable-model-invocation	true
description	Unified team skill for code review. 3-role pipeline: scanner, reviewer, fixer. Triggers on team-review.
allowed-tools	["Bash","Edit","Glob","Grep","Read","Write","followup_task","interrupt_agent","list_agents","mcp__maestro__team_msg","request_user_input","send_message","spawn_agent","spawn_agents_on_csv","update_plan","wait_agent"]
session-mode	run
version	0.5.83
contract	{"discovery":"self-described","consumes":[],"produces":[],"gates":{"entry":[],"exit":[]}}

Agent timeout: spawn_agent 异步执行且无内置超时 — 除明确短任务外一律 spawn_agent 后立即 wait_agent({ timeout_ms: 3600000 })（上限 1 小时）阻塞等待，绝不依赖 30000 默认值；timed_out: true 且 Agent 未完成时再次 wait_agent 续等，不丢弃。批量场景使用 spawn_agents_on_csv({ max_runtime_seconds: 3600, ... })。

<required_reading> @~/.maestro/workflows/run-mode-lite.md </required_reading>

Team Review

Orchestrate multi-agent code review: scanner -> reviewer -> fixer. Toolchain + LLM scan, deep analysis with root cause enrichment, and automated fix with rollback-on-failure.

Architecture

spawn_agent({ task_name: "team_review", message: "Execute skill team-review, args: task description" })
                    |
         SKILL.md (this file) = Router
                    |
     +--------------+--------------+
     |                             |
  no --role flag              --role <name>
     |                             |
  Coordinator                  Worker
  roles/coordinator/role.md    roles/<name>/role.md
     |
     +-- analyze -> dispatch -> spawn workers -> STOP
                                    |
                    +-------+-------+-------+
                    v       v       v
                [scan]  [review]  [fix]
                team-worker agents, each loads roles/<role>/role.md

Role Registry

Role	Path	Prefix	Inner Loop
coordinator	roles/coordinator/role.md	—	—
scanner	roles/scanner/role.md	SCAN-*	false
reviewer	roles/reviewer/role.md	REV-*	false
fixer	roles/fixer/role.md	FIX-*	true

Role Router

Parse $ARGUMENTS:

• Has --role <name> -> Read roles/<name>/role.md, execute Phase 2-4
• No --role -> @roles/coordinator/role.md, execute entry router

Shared Constants

• Session prefix: RV
• Session path: {run_dir}/work/team/
• Team name: review
• CLI tools: maestro delegate --mode analysis (read-only), maestro delegate --mode write (modifications)
• Message bus: mcp__maestro__team_msg(session_id=<run-id>, ...)

Worker Spawn Template

Coordinator spawns workers using this template:

spawn_agent({
  subagent_type: "team-worker",
  description: "Spawn <role> worker",
  team_name: "review",
  name: "<role>",
  run_in_background: true,
  prompt: `## Role Assignment
role: <role>
role_spec: <skill_root>/roles/<role>/role.md
session: {run_dir}/work/team
session_id: <run-id>
team_name: review
requirement: <task-description>
inner_loop: <true|false>

## Progress Milestones
session_id: <run-id>
Report progress via team_msg at natural phase boundaries (context loaded -> core work done -> verification).
Report blockers immediately via team_msg type="blocker".
Report completion via team_msg type="task_complete" after final send_message.

Read role_spec file (@<skill_root>/roles/<role>/role.md) to load Phase 2-4 domain instructions.
Execute built-in Phase 1 (task discovery) -> role Phase 2-4 -> built-in Phase 5 (report).`
})

User Commands

Command	Action
check / status	View pipeline status graph
resume / continue	Advance to next step
--full	Enable scan + review + fix pipeline
--fix	Fix-only mode (skip scan/review)
-q / --quick	Quick scan only
--dimensions=sec,cor,prf,mnt	Custom dimensions
-y / --yes	Skip confirmations

Completion Action

When pipeline completes, coordinator presents:

request_user_input({
  questions: [{
    question: "Review pipeline complete. What would you like to do?",
    header: "Completion",
    multiSelect: false,
    options: [
      { label: "Archive & Clean (Recommended)", description: "Archive session, clean up team" },
      { label: "Keep Active", description: "Keep session for follow-up work" },
      { label: "Export Results", description: "Export deliverables to target directory" }
    ]
  }]
})

Session Directory

{run_dir}/
├── outputs/
│   ├── scan/               # Scanner output
│   ├── review/             # Reviewer output
│   └── fix/                # Fixer output
├── report.md              # Human-readable synthesis + handoff
└── work/team/             # Team coordination (non-artifact)
    ├── .msg/messages.jsonl # Team message bus
    ├── .msg/meta.json      # Message-bus state + cross-role state
    └── wisdom/             # Cross-task knowledge

Specs Reference

• specs/pipelines.md — Pipeline definitions and task registry
• specs/dimensions.md — Review dimension definitions (SEC/COR/PRF/MNT)
• specs/finding-schema.json — Finding data schema
• specs/team-config.json — Team configuration

Error Handling

Scenario	Resolution
Unknown --role value	Error with available role list
Role not found	Error with expected path (roles//role.md)
CLI tool fails	Worker fallback to direct implementation
Scanner finds 0 findings	Report clean, skip review + fix
User declines fix	Delete FIX tasks, complete with review-only results
Fast-advance conflict	Coordinator reconciles on next callback
Completion action fails	Default to Keep Active