lisa-github-add-journey

name	lisa-github-add-journey
description	Add a Validation Journey…
allowed-tools	["Bash","Skill"]

Add Validation Journey to Existing GitHub Issue

Read an existing GitHub Issue, analyze the change type, and append a ## Validation Journey markdown section with appropriate verification steps based on the project's verification patterns.

Arguments

$ARGUMENTS: <ISSUE_REF>

• ISSUE_REF (required): GitHub issue ref — org/repo#<number> or full GitHub issue URL.

Prerequisites

• gh CLI authenticated (gh auth status).

Workflow

Step 1: Read the Issue

gh issue view <number> --repo <org>/<repo> --json number,title,body,labels,assignees,milestone,url

Extract: title, body, type (from type: label), components (from component: labels), assignees, linked PRs.

Step 2: Check for Existing Journey

Parse the body for an existing ## Validation Journey heading. It counts as complete only when the section contains at least one local typed [EVIDENCE: <artifact-type>: <name>] marker. An [EVIDENCE-REF: <work-item-ref> | <artifact-type>: <kebab-case-name>] is a non-claiming pointer and does not count; if references are present without a local claiming marker, continue drafting the missing local journey evidence instead of stopping.

Step 3: Analyze the Change Type

Examine the body, acceptance criteria, and codebase to determine the change type:

1. API/GraphQL changes — New or modified endpoints, request/response schemas
2. Database migration — Schema changes, new tables/columns, indexes
3. Background job/queue — New job processors, queue consumers, event handlers
4. Library/utility — Exported functions, shared modules, npm package changes
5. Security fix — Auth, authorization, input validation, OWASP vulnerabilities
6. Authentication/authorization — Role-based access, session management, tokens

Use Explore agents or read the codebase directly to understand which files are affected.

Step 4: Map Change Type to Verification Pattern

Change Type	Verification Approach
API/GraphQL	curl commands verifying endpoints, status codes, response schemas
Database migration	Migration execution + schema verification + rollback check
Background job/queue	Enqueue + process + state change verification
Library/utility	Test execution + build verification + export check
Security fix	Exploit reproduction pre-fix + exploit failure post-fix
Auth/authz	Multi-role verification with explicit status codes

Step 5: Draft the Validation Journey

Compose the journey with typed [EVIDENCE: <artifact-type>: <name>] markers at key verification points. The type says HOW the proof is captured (screenshot, recording, http-transcript, cli-output, log-snippet, db-query-output, perf-trace, test-run-log, deploy-log, state-dump — the fixed taxonomy in the verification rule); the name says WHAT it proves:

## Validation Journey

### Prerequisites
- List required services, database, env vars

### Steps
1. Verify current state before changes
2. Apply the change
3. Verify expected new state [EVIDENCE: http-transcript: health-endpoint-200]
4. Test error/edge cases [EVIDENCE: screenshot: invalid-input-error-state]
5. Verify rollback if applicable [EVIDENCE: db-query-output: rows-restored-after-rollback]

### Assertions
- Describe what must be true after verification

Guidelines for Drafting

1. 2–5 evidence markers — Focus on proving the change works and handles errors.
2. Concrete, runnable steps — Run \curl -s localhost:3000/health | jq .status`` not "Check the endpoint".
3. Include environment setup — Database connection, running services, env vars.
4. Markers are typed artifacts, not assertion labels — [EVIDENCE: <artifact-type>: <kebab-case-name>]. [EVIDENCE: load-failure-handled-gracefully] names a claim with nothing to capture; write [EVIDENCE: screenshot: load-failure-error-state] or [EVIDENCE: perf-trace: pipeline-load-tti]. Names are kebab-case and unique within the ticket.
5. Assertions are measurable — Returns 200 with {status: ok} not "API works correctly".
6. Cover happy path AND error path — At minimum, one success and one failure marker.
7. On a leaf work unit, the markers are binding — For a Bug / Task / Sub-task / Improvement, every typed [EVIDENCE: <artifact-type>: <name>] here is the issue's evidence manifest: validation gate S14 requires at least one, and the issue cannot be closed until each named artifact is captured in its declared type and attached (see the "Per-Work-Unit Evidence Contract" in the verification rule). Name only evidence you intend to capture — and name all of it.
8. Reference sibling evidence without claiming it — Use only [EVIDENCE-REF: <work-item-ref> | <artifact-type>: <kebab-case-name>] when prose points to an artifact declared by another issue. Never paste, quote, or code-format the sibling's [EVIDENCE: ...] marker: that exact prefix creates a local obligation. EVIDENCE-REF never satisfies this issue's S14 minimum, uniqueness check, capture list, or completion gate; a runtime-changing leaf still needs at least one local [EVIDENCE: ...] marker.

Step 6: Present to User for Approval

Display the drafted Validation Journey change and ask for confirmation before updating the issue body. (If invoked from a parent skill running unattended — e.g., lisa-github-write-issue Phase 6 step 5 — proceed without the prompt.)

Step 7: Merge into Issue Body

After approval:

current_body=$(gh issue view <number> --repo <org>/<repo> --json body --jq '.body')
# If no journey exists, append one section. If one exists without a local marker,
# merge the missing local steps/markers inside that section.
gh issue edit <number> --repo <org>/<repo> --body-file /tmp/updated-body.md

When repairing a reference-only journey, preserve all of its existing prose and EVIDENCE-REF pointers and append only the missing local steps/markers inside the existing section. Never create a second ## Validation Journey heading. Preserve every other section verbatim — never re-render the body from parsed fields, since the issue may carry extra_sections we don't recognize.

Step 8: Verify

Re-read the issue and confirm the ## Validation Journey section is present and includes at least one local [EVIDENCE: <artifact-type>: <name>] marker. An EVIDENCE-REF alone does not count.

When to Use This Skill

• Issue was created before the Validation Journey convention was established.
• Issue was created manually without following lisa-github-create guidelines.
• Issue needs a journey added or updated based on implementation progress.
• Before starting work on an issue, to ensure verification steps are documented.