| name | code-review |
| description | Review a code change independently for correctness, regression risk, maintainability, compatibility, tests, and unsafe assumptions. |
Code Review
Use when implementation exists and needs independent technical review.
Procedure
- Read the stated goal and acceptance criteria before inspecting the diff.
- Understand the changed behavior, boundaries, and affected callers or data paths.
- Look for correctness bugs, missing edge cases, state inconsistencies, error-handling gaps, compatibility breaks, unsafe concurrency, and hidden assumptions.
- Evaluate whether tests exercise the changed behavior and meaningful failure modes.
- Separate blocking findings from suggestions. Give each finding a precise location, consequence, and rationale.
- Verify suspicious claims by reading adjacent code or running targeted checks when practical.
- Re-review fixes to blocking findings.
Quality gate
A review should maximize signal. Do not bury important defects in style commentary or demand rewrites without a concrete engineering reason.