tidb-test-diff-triage

Triage unexpected TiDB test diffs that seem unrelated to the current PR. Use when plan/result/testdata changes appear after merge/rebase or only in specific local runs, especially to quickly rule in/out failpoint enablement issues.

跳到安装

仓库: pingcap/tidb
最近来源活动: 2026年3月12日 11:55
检测到的 SKILL.md 语言: 英语
星标: 40,465
分支: 6,229

安装方式

默认使用会先检查来源的 Prompt；你也可以切换为直接命令，或下载本地副本。

用 Codex 或 Claude 帮你安装复制这段 Prompt，粘贴到 Codex、Claude 或其他助手里，让它检查 Skill 页面并帮你完成安装。

直接命令不会经过审查 Prompt；运行前请先检查来源。

npx skills add https://github.com/pingcap/tidb --skill tidb-test-diff-triage

命令会保持在同一行。复制前请横向滚动并检查完整内容。

想先保存到本地？可下载 SkillsMP 当前能够提供的文件。

检查来源文件

决定是否安装前，请先阅读 SKILL.md，以及 SkillsMP 当前展示的配套文件。

SKILL.md

来源说明 · 只读预览

返回搜索返回安装

tidb-change-instruction-critic

Use when implementing a user- or reviewer-prescribed code change (including review comments with suggested fixes or options), especially when the requested edit may be risky, incomplete, ambiguous, or misaligned with TiDB correctness and compatibility constraints.

2026-05-25

tidb-bazel-prepare-gate

Use when deciding whether make bazel_prepare is required before build or test commands based on local file changes in TiDB.

2026-05-22

tidb-issue-metadata-guard

Use when creating or editing TiDB GitHub issues so issue templates, labels, issue titles, and issue descriptions stay consistent with repository workflow. Trigger on tasks involving issue creation, bug reports, enhancement tracking issues, label selection, or searching for existing issues and PRs before filing a new one.

2026-05-19

查看这个仓库的全部 Skills

TiDB Test Diff Triage

Trigger

Use this workflow when:

A test diff appears, but touched code in the PR does not explain that behavior change.

A single test run and full-suite run produce different outputs.

Planner/executor testdata changed unexpectedly after merge/rebase.

Rule 1: rule out failpoint setup first

In TiDB, many test behaviors rely on failpoint instrumentation. -tags=intest,deadlock does not enable failpoints.

Use docs/agents/testing-flow.md -> Failpoint decision for unit tests against the affected package.

If any hit exists, rerun with Failpoint-enabled run and add -count=1 to the go test command for reproducibility.

If the diff disappears after failpoint enable, classify it as an environment/setup issue instead of a logic regression.

Rule 2: isolate merge impact

If failpoint is not the cause:

Reproduce with minimal target (-run <TestName> -count=1).

Compare good/bad commits and bisect the merged range.

Identify first bad commit before updating expected outputs.

Useful commands:

git bisect start git bisect bad <bad_commit> git bisect good <good_commit>

Rule 3: update testdata only after the cause is proven

Only sync expected plan/result when one of these is true:

Upstream merge intentionally changed optimizer behavior.

Existing test expectation is stale but query semantics are unchanged.

Do not record/update testdata before root cause is identified.

Output format for investigation notes

Symptom: what diff changed.

Scope: single test vs full suite.

Failpoint check: commands and result.

First bad commit: hash and title (if bisected).

Conclusion: setup issue / upstream behavior change / local regression.

Action: rerun with failpoint, sync expected, or continue fixing code.

name	tidb-test-diff-triage
description	Triage unexpected TiDB test diffs that seem unrelated to the current PR. Use when plan/result/testdata changes appear after merge/rebase or only in specific local runs, especially to quickly rule in/out failpoint enablement issues.