菜单
Use when reviewing PRs, code changes, or conducting code audits in obsidian-terminal. Covers correctness, type safety, architecture fit, test coverage, localization, and completeness.
用 Codex 或 Claude 帮你安装 复制这段 Prompt，粘贴到 Codex、Claude 或其他助手里，让它检查 Skill 页面并帮你完成安装。
基于 SOC 职业分类
| name | code-review |
| description | Use when reviewing PRs, code changes, or conducting code audits in obsidian-terminal. Covers correctness, type safety, architecture fit, test coverage, localization, and completeness. |
Use this skill to perform structured, thorough code reviews of this repository. Follow the preparation steps, then check each dimension using its checklist.
git log --oneline HEAD...main, or check the PR's base branch).git diff <base>..<head> --stat.git diff <base>..<head>..ts, .json, .mjs, .md, etc.).src/terminal/view.ts changed, also read src/terminal/load.ts and relevant interfaces.await/.then() used correctly? Are promises caught?as casts (check project coding conventions — this repo disallows them).any types. unknown used where input is untrusted..fix() validators used to narrow unknown before use..fix() for settings validation, linkSetting/resetButton for UI, Manager classes for lifecycle.SettingsManager and LanguageManager as shown in src/main.ts.createI18n(PluginLocales.RESOURCES, ...) and language.value.t(...).src/ directory layout and naming conventions.tests/.*.spec.*) are fast, hermetic, BDD-style.*.test.*) are isolated and documented.vi.fn(), vi.spyOn(), vi.mocked() per conventions.vitest run is used (never watch mode) in automated flows.assets/locales/en/translation.json first.{{...}} placeholders and $t(...) calls kept intact, not translated.assets/locales/en/asset.json if a settings icon is needed.node scripts/sync-locale-keys.mjs to propagate to all locales..agents/instructions/localization.instructions.md.scripts/build.mjs have corresponding tests in tests/scripts/build.test.mjs.scripts/obsidian-install.mjs have corresponding tests in tests/scripts/obsidian-install.test.mjs.manifest.json changes are reflected in versions.json if needed..changeset/) with correct bump type (major/minor/patch) and PR reference.AGENTS.md updated if infra, testing conventions, or agent-visible patterns changed.false/opt-in for new features).data.json still loads).bun x vitest run).--stat shows all expected files and no unexpected ones.as, any, missing type guards.