- name
- review-code
- description
- Multi-dimensional code review with structured reports. Analyzes correctness, readability, performance, security, testing, and architecture. Triggers on "review code", "code review", "ๅฎกๆฅไปฃ็ ", "ไปฃ็ ๅฎกๆฅ".
- allowed-tools
- Agent, AskUserQuestion, Read, Write, Glob, Grep, Bash, mcp__ace-tool__search_context, mcp__ide__getDiagnostics
# Review Code
Multi-dimensional code review skill that analyzes code across 6 key dimensions and generates structured review reports with actionable recommendations.
## Architecture Overview
```
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
โ โ ๏ธ Phase 0: Specification Study (ๅผบๅถๅ็ฝฎ) โ
โ โ ้
่ฏป specs/review-dimensions.md โ
โ โ ็่งฃๅฎกๆฅ็ปดๅบฆๅ้ฎ้ขๅ็ฑปๆ ๅ โ
โโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
โ Orchestrator (็ถๆ้ฉฑๅจๅณ็ญ) โ
โ โ ่ฏปๅ็ถๆ โ ้ๆฉๅฎกๆฅๅจไฝ โ ๆง่ก โ ๆดๆฐ็ถๆ โ
โโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
โ
โโโโโโโโโโโโโผโโโโโโโโโโโโฌโโโโโโโโโโโโฌโโโโโโโโโโโโ
โ โ โ โ โ
โโโโโโโโโโโ โโโโโโโโโโโ โโโโโโโโโโโ โโโโโโโโโโโ โโโโโโโโโโโ
โ Collect โ โ Quick โ โ Deep โ โ Report โ โComplete โ
โ Context โ โ Scan โ โ Review โ โ Generateโ โ โ
โโโโโโโโโโโ โโโโโโโโโโโ โโโโโโโโโโโ โโโโโโโโโโโ โโโโโโโโโโโ
โ โ โ โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
โ Review Dimensions โ
โ โโโโโโโโโโโโ โโโโโโโโโโโโ โโโโโโโโโโโโ โโโโโโโโโโโโ โ
โ โCorrectnessโ โReadabilityโ โPerformanceโ โ Security โ โ
โ โโโโโโโโโโโโ โโโโโโโโโโโโ โโโโโโโโโโโโ โโโโโโโโโโโโ โ
โ โโโโโโโโโโโโ โโโโโโโโโโโโ โ
โ โ Testing โ โArchitectureโ โ
โ โโโโโโโโโโโโ โโโโโโโโโโโโ โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
```
**Project Context**: Run `ccw spec load --category review` for review standards, checklists, and approval gates.
## Key Design Principles
1. **ๅค็ปดๅบฆๅฎกๆฅ**: ่ฆ็ๆญฃ็กฎๆงใๅฏ่ฏปๆงใๆง่ฝใๅฎๅ
จๆงใๆต่ฏ่ฆ็ใๆถๆไธ่ดๆงๅ
ญๅคง็ปดๅบฆ
2. **ๅๅฑๆง่ก**: ๅฟซ้ๆซๆ่ฏๅซ้ซ้ฃ้ฉๅบๅ๏ผๆทฑๅ
ฅๅฎกๆฅ่็ฆๅ
ณ้ฎ้ฎ้ข
3. **็ปๆๅๆฅๅ**: ๆไธฅ้็จๅบฆๅ็ฑป๏ผๆไพๆไปถไฝ็ฝฎๅไฟฎๅคๅปบ่ฎฎ
4. **็ถๆ้ฉฑๅจ**: ่ชไธปๆจกๅผ๏ผๆ นๆฎๅฎกๆฅ่ฟๅบฆๅจๆ้ๆฉไธไธๆญฅๅจไฝ
---
## โ ๏ธ Mandatory Prerequisites (ๅผบๅถๅ็ฝฎๆกไปถ)
> **โ ็ฆๆญข่ทณ่ฟ**: ๅจๆง่กไปปไฝๅฎกๆฅๆไฝไนๅ๏ผ**ๅฟ
้กป**ๅฎๆด้
่ฏปไปฅไธๆๆกฃใ
### ่ง่ๆๆกฃ (ๅฟ
่ฏป)
| Document | Purpose | Priority |
|----------|---------|----------|
| [specs/review-dimensions.md](specs/review-dimensions.md) | ๅฎกๆฅ็ปดๅบฆๅฎไนๅๆฃๆฅ็น | **P0 - ๆ้ซ** |
| [specs/issue-classification.md](specs/issue-classification.md) | ้ฎ้ขๅ็ฑปๅไธฅ้็จๅบฆๆ ๅ | **P0 - ๆ้ซ** |
| [specs/quality-standards.md](specs/quality-standards.md) | ๅฎกๆฅ่ดจ้ๆ ๅ | P1 |
### ๆจกๆฟๆไปถ (็ๆๅๅฟ
่ฏป)
| Document | Purpose |
|----------|---------|
| [templates/review-report.md](templates/review-report.md) | ๅฎกๆฅๆฅๅๆจกๆฟ |
| [templates/issue-template.md](templates/issue-template.md) | ้ฎ้ข่ฎฐๅฝๆจกๆฟ |
---
## Execution Flow
```
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
โ Phase 0: Specification Study (ๅผบๅถๅ็ฝฎ - ็ฆๆญข่ทณ่ฟ) โ
โ โ Read: specs/review-dimensions.md โ
โ โ Read: specs/issue-classification.md โ
โ โ ็่งฃๅฎกๆฅๆ ๅๅ้ฎ้ขๅ็ฑป โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโค
โ Action: collect-context โ
โ โ ๆถ้็ฎๆ ๆไปถ/็ฎๅฝ โ
โ โ ่ฏๅซๆๆฏๆ ๅ่ฏญ่จ โ
โ โ Output: state.context (files, language, framework) โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโค
โ Action: quick-scan โ
โ โ ๅฟซ้ๆซๆๆดไฝ็ปๆ โ
โ โ ่ฏๅซ้ซ้ฃ้ฉๅบๅ โ
โ โ Output: state.risk_areas, state.scan_summary โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโค
โ Action: deep-review (per dimension) โ
โ โ ้็ปดๅบฆๆทฑๅ
ฅๅฎกๆฅ โ
โ โ ่ฎฐๅฝๅ็ฐ็้ฎ้ข โ
โ โ Output: state.findings[] โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโค
โ Action: generate-report โ
โ โ ๆฑๆปๆๆๅ็ฐ โ
โ โ ็ๆ็ปๆๅๆฅๅ โ
โ โ Output: review-report.md โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโค
โ Action: complete โ
โ โ ไฟๅญๆ็ป็ถๆ โ
โ โ ่พๅบๅฎกๆฅๆ่ฆ โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
```
## Directory Setup
```javascript
const timestamp = new Date().toISOString().slice(0,19).replace(/[-:T]/g, '');
const workDir = `.workflow/.scratchpad/review-code-${timestamp}`;
Bash(`mkdir -p "${workDir}"`);
Bash(`mkdir -p "${workDir}/findings"`);
```
## Output Structure
```
.workflow/.scratchpad/review-code-{timestamp}/
โโโ state.json # ๅฎกๆฅ็ถๆ
โโโ context.json # ็ฎๆ ไธไธๆ
โโโ findings/ # ้ฎ้ขๅ็ฐ
โ โโโ correctness.json
โ โโโ readability.json
โ โโโ performance.json
โ โโโ security.json
โ โโโ testing.json
โ โโโ architecture.json
โโโ review-report.md # ๆ็ปๅฎกๆฅๆฅๅ
```
## Review Dimensions
| Dimension | Focus Areas | Key Checks |
|-----------|-------------|------------|
| **Correctness** | ้ป่พๆญฃ็กฎๆง | ่พน็ๆกไปถใ้่ฏฏๅค็ใnull ๆฃๆฅ |
| **Readability** | ไปฃ็ ๅฏ่ฏปๆง | ๅฝๅ่ง่ใๅฝๆฐ้ฟๅบฆใๆณจ้่ดจ้ |
| **Performance** | ๆง่ฝๆ็ | ็ฎๆณๅคๆๅบฆใI/O ไผๅใ่ตๆบไฝฟ็จ |
| **Security** | ๅฎๅ
จๆง | ๆณจๅ
ฅ้ฃ้ฉใๆๆไฟกๆฏใๆ้ๆงๅถ |
| **Testing** | ๆต่ฏ่ฆ็ | ๆต่ฏๅ
ๅๆงใ่พน็่ฆ็ใๅฏ็ปดๆคๆง |
| **Architecture** | ๆถๆไธ่ดๆง | ่ฎพ่ฎกๆจกๅผใๅๅฑ็ปๆใไพ่ต็ฎก็ |
## Issue Severity Levels
| Level | Prefix | Description | Action Required |
|-------|--------|-------------|-----------------|
| **Critical** | [C] | ้ปๅกๆง้ฎ้ข๏ผๅฟ
้กป็ซๅณไฟฎๅค | Must fix before merge |
| **High** | [H] | ้่ฆ้ฎ้ข๏ผ้่ฆไฟฎๅค | Should fix |
| **Medium** | [M] | ๅปบ่ฎฎๆน่ฟ | Consider fixing |
| **Low** | [L] | ๅฏ้ไผๅ | Nice to have |
| **Info** | [I] | ไฟกๆฏๆงๅปบ่ฎฎ | For reference |
## Reference Documents
| Document | Purpose |
|----------|---------|
| [phases/orchestrator.md](phases/orchestrator.md) | ๅฎกๆฅ็ผๆๅจ |
| [phases/state-schema.md](phases/state-schema.md) | ็ถๆ็ปๆๅฎไน |
| [phases/actions/action-collect-context.md](phases/actions/action-collect-context.md) | ๆถ้ไธไธๆ |
| [phases/actions/action-quick-scan.md](phases/actions/action-quick-scan.md) | ๅฟซ้ๆซๆ |
| [phases/actions/action-deep-review.md](phases/actions/action-deep-review.md) | ๆทฑๅ
ฅๅฎกๆฅ |
| [phases/actions/action-generate-report.md](phases/actions/action-generate-report.md) | ็ๆๆฅๅ |
| [phases/actions/action-complete.md](phases/actions/action-complete.md) | ๅฎๆๅฎกๆฅ |
| [specs/review-dimensions.md](specs/review-dimensions.md) | ๅฎกๆฅ็ปดๅบฆ่ง่ |
| [specs/issue-classification.md](specs/issue-classification.md) | ้ฎ้ขๅ็ฑปๆ ๅ |
| [specs/quality-standards.md](specs/quality-standards.md) | ่ดจ้ๆ ๅ |
| [templates/review-report.md](templates/review-report.md) | ๆฅๅๆจกๆฟ |
| [templates/issue-template.md](templates/issue-template.md) | ้ฎ้ขๆจกๆฟ |
Auf GitHub ansehen