code-review

name	code-review
description	Review a PR for quality, security, and standards compliance. Invokes the Code Reviewer agent (Rex).
disable-model-invocation	true
argument-hint	<pr-number> [repo]
allowed-tools	Bash, Read, Grep, Glob

/code-review — Code Review

Review a pull request for quality, security, and adherence to standards.

LSP-aware (optional, recommended)

This skill performs semantic code navigation — finding definitions, walking references, tracing handlers across modules. With LSP enabled (ENABLE_LSP_TOOL=1 + per-language plugin per docs/getting-started.md), queries are ~3-15× cheaper in token cost than grep + Read. Without LSP, the skill falls back to grep + Read transparently — no new failure mode, just optional speed.

Per-language LSP plugins live in Claude Code's marketplace. Install once; the skill detects the active language and dispatches automatically.

Activated agent + role

When /code-review runs:

1. Primary reviewer: the Code Reviewer agent (Rex) at .claude/agents/code-reviewer.md — runs on every commit, owns the automated first-pass review.
2. Human approval gate: the Tech Lead — activates to sign off on architecture, design patterns, and team conventions that Rex can't judge from code alone.
3. Conditional Security Auditor: if the diff touches **/auth/**, **/crypto/**, **/secrets/**, .env*, or similar, the Security Auditor also activates and must sign off before merge. Consider chaining /security-review for the deeper pass.
4. Conditional UI Designer: if the diff touches visible UI, the UI Designer activates for design review.

See .claude/rules/role-triggers.md for the full activation protocol.

Usage

/code-review 30
/code-review 30 your-org/your-repo

Process

0. Write the active-reviewer marker (REQUIRED — me2resh/apexyard#843)

Before spawning the Code Reviewer agent (Rex), write the active-reviewer session marker so warn-review-marker-write.sh lets Rex's *-rex.approved write through the blocking marker gate. At skill entry:

ops_root=$(git rev-parse --show-toplevel)
r="$ops_root"
while [ -n "$r" ] && [ "$r" != "/" ]; do
  [ -f "$r/.apexyard-fork" ] && { ops_root="$r"; break; }
  [ -f "$r/onboarding.yaml" ] && [ -f "$r/apexyard.projects.yaml" ] && { ops_root="$r"; break; }
  r=$(dirname "$r")
done
mkdir -p "$ops_root/.claude/session"
printf '%s\n' "<owner/repo>#<pr>:rex" > "$ops_root/.claude/session/active-reviewer"

On skill exit (after Rex posts its verdict, whether APPROVED or CHANGES REQUESTED), clear the marker:

rm -f "$ops_root/.claude/session/active-reviewer"

Without this marker, a build-class sub-agent attempting the same write is correctly blocked — see .claude/hooks/warn-review-marker-write.sh and .claude/rules/pr-workflow.md § "Build agents cannot self-review".

1. Fetch PR details and the latest commit SHA
2. Get the diff
3. Review against the checklist (architecture, code quality, testing, security, performance)
4. Check for the required Glossary section
5. Check for AgDR links if technical decisions were made
6. On JS/TS diffs, run the Fallow static-analysis pass (§ 9 of the agent) — changed-scope, fail-soft, advisory; render a ### Fallow Findings table + dry-run fix preview
7. Submit the review through the tracker-agnostic tracker_review_submit (gh PR / glab MR / custom host — #758), not a hardcoded gh pr review, then clear the active-reviewer marker from step 0

Review Checklist

Architecture

• Domain layer has no external dependencies
• Application layer doesn't import infrastructure
• Proper separation of commands vs queries

Code Quality

• Type-safety enforced
• No unjustified any types
• Proper error handling
• Clear naming conventions

Testing

• Unit tests for domain logic
• Tests test behavior, not implementation
• Edge cases covered

Security

• No secrets in code
• Input validation present
• No injection vulnerabilities

PR Description

• Links to the ticket
• Has a Glossary section (REQUIRED — request changes if missing)
• AgDR links if decisions were made

Technical Decisions (AgDR) — BLOCKING

Scan the diff for unrecorded decisions:

• New dependencies / libraries in build files
• New frameworks (ORM, queue, cache, etc.)
• Architecture patterns implemented
• Design pattern choices

If a decision is detected but no AgDR is linked:

1. REQUEST CHANGES (do not approve)
2. List the specific decisions found
3. Instruct the author to run /decide
4. The PR cannot merge until the AgDR is linked

Output

Posts a GitHub review comment with:

• Commit SHA reviewed
• Checklist results
• Issues found
• Fallow findings (advisory; JS/TS diffs only, when the fallow CLI is available)
• Verdict: APPROVED / CHANGES REQUESTED / COMMENT

Invokes: Code Reviewer Agent (Rex)

---

Part of ApexYard — multi-project SDLC framework for Claude Code · MIT.