code-review-personal

# Code Review Personal ## Workflow 1. Run `git diff main...HEAD` to inspect all branch changes. 2. Load context from `FEATURE_PLAN.md`, `feature_summary.md`, any `{git-root}/docs/feature-summary*.md` files, or task-prefixed `T*-feature-summary*.md` files if they exist (prefer the most recent summary). 3. Load context from `ORIGINAL_PLAN.md` if it exists. 4. Review all changes against the criteria below. ## Review Criteria ### Functionality - Verify code matches feature intent from plan files. - Check edge-case handling. - Check error handling appropriateness. - Flag obvious bugs or behavioral regressions. ### Code Quality - Check readability, consistency, and organization. - Prefer single-purpose functions. - Check naming clarity. - Enforce project conventions. ### Security and Privacy - Flag sensitive data logging (raw transactions, account numbers, CSV rows). - Check input validation where needed. - Flag hardcoded secrets or credential-like values. ### Performance - Flag inefficient algorithms or query patterns. - Flag potential N+1 access patterns. - Flag unnecessary recomputation or heavy work. ### Tests - Check whether tests cover new behavior and risk areas. - Prefer behavior-focused tests over brittle implementation-coupled tests. - If tests are missing, recommend `/write-tests`. ## Output Format Provide all sections in this order: 1. Executive Summary (1-2 paragraphs) 2. Findings by Severity (Critical > Major > Minor > Cosmetic) 3. Test Coverage Assessment 4. Final Verdict: `Ready to merge` | `Needs minor cleanup` | `Needs major revisions` ## Ground Rules - Prioritize findings and risks over praise. - Keep findings specific and actionable. - Reference concrete file paths and lines when possible. - If no findings exist, state that explicitly and note residual risk/testing gaps.